-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(npm-scripts): support windows platform using cross-var
#3857
fix(npm-scripts): support windows platform using cross-var
#3857
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3857 +/- ##
==========================================
- Coverage 92.98% 92.97% -0.02%
==========================================
Files 300 300
Lines 9104 9104
Branches 1862 1862
==========================================
- Hits 8465 8464 -1
- Misses 639 640 +1 |
8bbd6ff
to
c4c1621
Compare
c4c1621
to
fe7b4cb
Compare
In contrib repo we directly used the package name instead of But more general I wonder why there are still Maybe we should just remove these npm scripts? |
If you want to just compile one package and its dependency, you can just go under the package directory and run |
Either using env var or hard code the package name is okay. |
Which problem is this PR solving?
Currently, the project cannot run on Windows because the npm script:
Windows doesn't support inline shell scripts like this.
But we can use
npm_package_name
env var instead.But Linux/macOS uses
$
style env var references while Windows uses%%
style.Short description of the changes
cross-var
as adevDependency
and modified the npm script to support Windows.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
npm run compile
on Windows machines.Checklist: