-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-logs): add ObservedTimestamp
to LogRecord
#3787
feat(api-logs): add ObservedTimestamp
to LogRecord
#3787
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 295 295
Lines 9038 9039 +1
Branches 1842 1843 +1
=======================================
+ Hits 8401 8402 +1
Misses 637 637
|
7af7fbf
to
0451321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good but you have to be very extra sure you want hrTime
if you're going to use it. I personally would recommend using Date.now
cdb9c72
to
84125dc
Compare
Which problem is this PR solving?
Adds
ObservedTimestamp
toLogRecord
according to the specification.Fixes #3757
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: