Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter-logs-otlp-proto): implements protobuf exporter for logs #3779

Merged
merged 20 commits into from
Jun 2, 2023

Conversation

Abinet18
Copy link
Contributor

@Abinet18 Abinet18 commented May 3, 2023

Which problem is this PR solving?

Adds a protobuf exporter for logs.

Short description of the changes

Create a new package for exporter-logs-otlp-proto

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested in a browser app that uses the OTLPLogs exporter to export sample events

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Abinet18 Abinet18 requested a review from a team May 3, 2023 21:44
@Abinet18 Abinet18 changed the title Logs exporter otlp proto feat(exporter-logs-otlp-http): implements protobuf exporter for logs May 3, 2023
@Abinet18 Abinet18 changed the title feat(exporter-logs-otlp-http): implements protobuf exporter for logs feat(exporter-logs-otlp-proto): implements protobuf exporter for logs May 4, 2023
@Abinet18 Abinet18 force-pushed the logs-exporter-otlp-proto branch from 256b03d to e4a48b9 Compare May 4, 2023 20:38
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #3779 (c6cf1e9) into main (05bcd82) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c6cf1e9 differs from pull request most recent head 034d693. Consider uploading reports for the commit 034d693 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3779      +/-   ##
==========================================
+ Coverage   92.96%   92.98%   +0.01%     
==========================================
  Files         299      300       +1     
  Lines        9082     9104      +22     
  Branches     1855     1862       +7     
==========================================
+ Hits         8443     8465      +22     
  Misses        639      639              
Impacted Files Coverage Δ
...s-otlp-proto/src/platform/node/OTLPLogsExporter.ts 100.00% <100.00%> (ø)

@Abinet18 Abinet18 force-pushed the logs-exporter-otlp-proto branch from adbdf8f to 1f8180e Compare May 4, 2023 20:56
@Abinet18 Abinet18 force-pushed the logs-exporter-otlp-proto branch from 3911bd0 to 2706824 Compare May 16, 2023 18:34
@Abinet18 Abinet18 force-pushed the logs-exporter-otlp-proto branch from 952f263 to 13e77df Compare May 26, 2023 18:17
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, then this should be good to go 🙂

@pichlermarc pichlermarc merged commit 1fc4ac6 into open-telemetry:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants