Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otlp-exporter-base): fix changelog for merged retry pr #3650

Merged

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Mar 1, 2023

Which problem is this PR solving?

When this retry pr was merged, the changelog was in the wrong place. This retry feature hasn't been released yet so the changelog needs to be under Unreleased.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@svetlanabrennan svetlanabrennan requested a review from a team March 1, 2023 22:12
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #3650 (088cb1d) into main (0fb7879) will not change coverage.
The diff coverage is n/a.

❗ Current head 088cb1d differs from pull request most recent head 53d2e99. Consider uploading reports for the commit 53d2e99 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3650   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files         274      274           
  Lines        8060     8060           
  Branches     1671     1671           
=======================================
  Hits         7555     7555           
  Misses        505      505           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up on this 🙂

@pichlermarc pichlermarc merged commit 494efff into open-telemetry:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants