Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-node): install diag logger with OTEL_LOG_LEVEL #3627

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Register diag logger with environ OTEL_LOG_LEVEL.

Fixes #3312

Short description of the changes

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • diag.setLogger invoked with the expected log level and DiagConsoleLogger.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@legendecas legendecas requested a review from a team February 22, 2023 07:40
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3627 (87cc86d) into main (86973eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 87cc86d differs from pull request most recent head d00c09c. Consider uploading reports for the commit d00c09c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3627   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         268      268           
  Lines        7927     7930    +3     
  Branches     1643     1644    +1     
=======================================
+ Hits         7454     7457    +3     
  Misses        473      473           
Impacted Files Coverage Δ
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 93.75% <100.00%> (+0.20%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support environment variable OTEL_LOG_LEVEL
2 participants