Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Martin Kuba to approvers list #3594

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Feb 7, 2023

The JS maintainers would like to welcome Martin Kuba as the newest JS approver.

@dyladan dyladan requested a review from a team February 7, 2023 15:47
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3594 (9f1b95d) into main (92fbec9) will decrease coverage by 3.10%.
The diff coverage is n/a.

❗ Current head 9f1b95d differs from pull request most recent head 0b1195f. Consider uploading reports for the commit 0b1195f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3594      +/-   ##
==========================================
- Coverage   93.93%   90.84%   -3.10%     
==========================================
  Files         260       77     -183     
  Lines        7799     1671    -6128     
  Branches     1619      339    -1280     
==========================================
- Hits         7326     1518    -5808     
+ Misses        473      153     -320     
Impacted Files Coverage Δ
api/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
packages/opentelemetry-sdk-trace-web/src/utils.ts 65.83% <0.00%> (-29.20%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
api/src/baggage/utils.ts 100.00% <0.00%> (ø)
...ental/packages/otlp-grpc-exporter-base/src/util.ts
packages/opentelemetry-core/src/utils/wrap.ts
...es/opentelemetry-context-zone-peer-dep/src/util.ts
...elemetry-propagator-jaeger/src/JaegerPropagator.ts
packages/sdk-metrics/src/Instruments.ts
... and 179 more

@dyladan dyladan merged commit cb88e4e into open-telemetry:main Feb 8, 2023
@dyladan dyladan deleted the martin-approver branch February 8, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants