feat(sdk-trace-base): add dropped attributes and events count on span

experimental/packages/exporter-trace-otlp-grpc/test/traceHelper.ts

@@ -91,6 +91,9 @@ export const mockedReadableSpan: ReadableSpan = {
     })
   ),
   instrumentationLibrary: { name: 'default', version: '0.0.1' },
+  droppedAttributesCount: 0,
+  droppedEventsCount: 0,
+  droppedLinksCount: 0,
 };
 
 export function ensureExportedEventsAreCorrect(events: IEvent[]) {

experimental/packages/exporter-trace-otlp-http/test/traceHelper.ts

@@ -102,6 +102,9 @@ export const mockedReadableSpan: ReadableSpan = {
     })
   ),
   instrumentationLibrary: { name: 'default', version: '0.0.1' },
+  droppedAttributesCount: 0,
+  droppedEventsCount: 0,
+  droppedLinksCount: 0,
 };
 
 export const mockedResources: Resource[] = [
@@ -142,6 +145,9 @@ export const basicTrace: ReadableSpan[] = [
     duration: [0, 8885000],
     resource: mockedResources[0],
     instrumentationLibrary: mockedInstrumentationLibraries[0],
+    droppedAttributesCount: 0,
+    droppedEventsCount: 0,
+    droppedLinksCount: 0,
   },
   {
     name: 'span2',
@@ -164,6 +170,9 @@ export const basicTrace: ReadableSpan[] = [
     duration: [0, 8775000],
     resource: mockedResources[0],
     instrumentationLibrary: mockedInstrumentationLibraries[0],
+    droppedAttributesCount: 0,
+    droppedEventsCount: 0,
+    droppedLinksCount: 0,
   },
   {
     name: 'span3',
@@ -186,6 +195,9 @@ export const basicTrace: ReadableSpan[] = [
     duration: [0, 8775000],
     resource: mockedResources[0],
     instrumentationLibrary: mockedInstrumentationLibraries[0],
+    droppedAttributesCount: 0,
+    droppedEventsCount: 0,
+    droppedLinksCount: 0,
   },
 ];
 

experimental/packages/exporter-trace-otlp-proto/test/traceHelper.ts

@@ -87,6 +87,9 @@ export const mockedReadableSpan: ReadableSpan = {
     cost: 112.12,
   }),
   instrumentationLibrary: { name: 'default', version: '0.0.1' },
+  droppedAttributesCount: 0,
+  droppedEventsCount: 0,
+  droppedLinksCount: 0,
 };
 
 export function ensureProtoEventsAreCorrect(events: IEvent[]) {

experimental/packages/otlp-grpc-exporter-base/test/traceHelper.ts

@@ -91,6 +91,9 @@ export const mockedReadableSpan: ReadableSpan = {
     })
   ),
   instrumentationLibrary: { name: 'default', version: '0.0.1' },
+  droppedAttributesCount: 0,
+  droppedEventsCount: 0,
+  droppedLinksCount: 0,
 };
 
 export function ensureExportedEventsAreCorrect(events: IEvent[]) {

experimental/packages/otlp-proto-exporter-base/tsconfig.esnext.json

@@ -1,9 +1,8 @@
 {
   "extends": "../../../tsconfig.base.esnext.json",
   "compilerOptions": {
-    "allowJs": true,
-    "outDir": "build/esnext",
     "rootDir": "src",
+    "outDir": "build/esnext",
     "tsBuildInfoFile": "build/esnext/tsconfig.esnext.tsbuildinfo"
   },
   "include": [

experimental/packages/otlp-transformer/test/trace.test.ts

@@ -178,6 +178,9 @@ describe('Trace', () => {
         status: {
           code: SpanStatusCode.OK,
         },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
     });
 

packages/opentelemetry-exporter-jaeger/test/jaeger.test.ts

@@ -53,6 +53,9 @@ describe('JaegerExporter', () => {
       name: 'default',
       version: '0.0.1',
     },
+    droppedAttributesCount: 0,
+    droppedEventsCount: 0,
+    droppedLinksCount: 0,
   };
   describe('constructor', () => {
     afterEach(() => {

packages/opentelemetry-exporter-jaeger/test/transform.test.ts

@@ -82,6 +82,9 @@ describe('transform', () => {
           name: 'default',
           version: '0.0.1',
         },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
 
       const thriftSpan = spanToThrift(readableSpan);
@@ -179,6 +182,9 @@ describe('transform', () => {
           name: 'default',
           version: '0.0.1',
         },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
 
       const thriftSpan = spanToThrift(readableSpan);
@@ -246,6 +252,9 @@ describe('transform', () => {
           name: 'default',
           version: '0.0.1',
         },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
 
       const thriftSpan = spanToThrift(readableSpan);
@@ -291,6 +300,9 @@ describe('transform', () => {
           name: 'default',
           version: '0.0.1',
         },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
 
       const thriftSpan = spanToThrift(readableSpan);
@@ -353,6 +365,9 @@ describe('transform', () => {
           name: 'default',
           version: '0.0.1',
         },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
       let thriftSpan = spanToThrift(readableSpan);
       assert.strictEqual(

packages/opentelemetry-exporter-zipkin/test/helper.ts

@@ -45,6 +45,9 @@ export const mockedReadableSpan: ReadableSpan = {
     cost: 112.12,
   }),
   instrumentationLibrary: { name: 'default', version: '0.0.1' },
+  droppedAttributesCount: 0,
+  droppedEventsCount: 0,
+  droppedLinksCount: 0,
 };
 
 export function ensureHeadersContain(

packages/opentelemetry-exporter-zipkin/test/node/zipkin.test.ts

@@ -56,6 +56,9 @@ function getReadableSpan() {
     events: [],
     resource: Resource.empty(),
     instrumentationLibrary: { name: 'default', version: '0.0.1' },
+    droppedAttributesCount: 0,
+    droppedEventsCount: 0,
+    droppedLinksCount: 0,
   };
   return readableSpan;
 }
@@ -164,6 +167,9 @@ describe('Zipkin Exporter - node', () => {
         ],
         resource: Resource.empty(),
         instrumentationLibrary: { name: 'default', version: '0.0.1' },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
       const span2: ReadableSpan = {
         name: 'my-span',
@@ -187,6 +193,9 @@ describe('Zipkin Exporter - node', () => {
         events: [],
         resource: Resource.empty(),
         instrumentationLibrary: { name: 'default', version: '0.0.1' },
+        droppedAttributesCount: 0,
+        droppedEventsCount: 0,
+        droppedLinksCount: 0,
       };
 
       const exporter = new ZipkinExporter({
@@ -379,6 +388,9 @@ describe('Zipkin Exporter - node', () => {
         [SemanticResourceAttributes.SERVICE_NAME]: resource_service_name,
       }),
       instrumentationLibrary: { name: 'default', version: '0.0.1' },
+      droppedAttributesCount: 0,
+      droppedEventsCount: 0,
+      droppedLinksCount: 0,
     };
     const span2: ReadableSpan = {
       name: 'my-span',
@@ -402,6 +414,9 @@ describe('Zipkin Exporter - node', () => {
         [SemanticResourceAttributes.SERVICE_NAME]: resource_service_name_prime,
       }),
       instrumentationLibrary: { name: 'default', version: '0.0.1' },
+      droppedAttributesCount: 0,
+      droppedEventsCount: 0,
+      droppedLinksCount: 0,
     };
 
     const exporter = new ZipkinExporter({});
@@ -467,6 +482,9 @@ describe('Zipkin Exporter - node', () => {
       ],
       resource: Resource.empty(),
       instrumentationLibrary: { name: 'default', version: '0.0.1' },
+      droppedAttributesCount: 0,
+      droppedEventsCount: 0,
+      droppedLinksCount: 0,
     };
     const span2: ReadableSpan = {
       name: 'my-span',
@@ -490,6 +508,9 @@ describe('Zipkin Exporter - node', () => {
       events: [],
       resource: Resource.empty(),
       instrumentationLibrary: { name: 'default', version: '0.0.1' },
+      droppedAttributesCount: 0,
+      droppedEventsCount: 0,
+      droppedLinksCount: 0,
     };
 
     const exporter = new ZipkinExporter({});

packages/opentelemetry-sdk-trace-base/src/Span.ts

@@ -66,6 +66,10 @@ export class Span implements APISpan, ReadableSpan {
   readonly startTime: HrTime;
   readonly resource: Resource;
   readonly instrumentationLibrary: InstrumentationLibrary;
+  droppedAttributesCount: number = 0;
+  droppedEventsCount: number = 0;
+  droppedLinksCount: number = 0;
+
   name: string;
   status: SpanStatus = {
     code: SpanStatusCode.UNSET,
@@ -141,6 +145,7 @@ export class Span implements APISpan, ReadableSpan {
         this._spanLimits.attributeCountLimit! &&
       !Object.prototype.hasOwnProperty.call(this.attributes, key)
     ) {
+      this.droppedAttributesCount += 1;
       return this;
     }
     this.attributes[key] = this._truncateToSize(value);
@@ -167,14 +172,6 @@ export class Span implements APISpan, ReadableSpan {
     timeStamp?: TimeInput
   ): this {
     if (this._isSpanEnded()) return this;
-    if (this._spanLimits.eventCountLimit === 0) {
-      diag.warn('No events allowed.');
-      return this;
-    }
-    if (this.events.length >= this._spanLimits.eventCountLimit!) {
-      diag.warn('Dropping extra events.');
-      this.events.shift();
-    }
 
     if (isTimeInput(attributesOrStartTime)) {
       if (!isTimeInput(timeStamp)) {
@@ -184,6 +181,18 @@ export class Span implements APISpan, ReadableSpan {
     }
 
     const attributes = sanitizeAttributes(attributesOrStartTime);
+
+    if (this._spanLimits.eventCountLimit === 0) {
+      diag.warn('No events allowed.');
+      this.droppedEventsCount += 1;
+      return this;
+    }
+    if (this.events.length >= this._spanLimits.eventCountLimit!) {
+      diag.warn('Dropping extra events.');
+      this.events.shift();
+      this.droppedEventsCount += 1;
+    }
+
     this.events.push({
       name,
       attributes,

packages/opentelemetry-sdk-trace-base/src/export/ReadableSpan.ts

@@ -41,4 +41,7 @@ export interface ReadableSpan {
   readonly ended: boolean;
   readonly resource: Resource;
   readonly instrumentationLibrary: InstrumentationLibrary;
+  readonly droppedAttributesCount: number;
+  readonly droppedEventsCount: number;
+  readonly droppedLinksCount: number;
 }

packages/opentelemetry-sdk-trace-base/test/common/Span.test.ts

@@ -312,6 +312,10 @@ describe('Span', () => {
           assert.strictEqual(span.attributes['foo99'], 'bar99');
           assert.strictEqual(span.attributes['foo149'], undefined);
         });
+
+        it('should store the count of dropped attributes in droppedAttributesCount', () => {
+          assert.strictEqual(span.droppedAttributesCount, 50);
+        });
       });
 
       describe('when "attributeValueLengthLimit" option defined', () => {
@@ -791,6 +795,22 @@ describe('Span', () => {
     assert.strictEqual(span.events[span.events.length - 1].name, 'sent149');
   });
 
+  it('should store the count of dropped events in droppedEventsCount', () => {
+    const span = new Span(
+      tracer,
+      ROOT_CONTEXT,
+      name,
+      spanContext,
+      SpanKind.CLIENT
+    );
+    for (let i = 0; i < 150; i++) {
+      span.addEvent('sent' + i);
+    }
+    span.end();
+
+    assert.strictEqual(span.droppedEventsCount, 50);
+  });
+
   it('should add no event', () => {
     const tracer = new BasicTracerProvider({
       spanLimits: {