Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): Fix typo in Resource.default docstring #3547

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

yehonatanz
Copy link
Contributor

Which problem is this PR solving?

A meaningless typo in Resource.default docstring that bothered me.

Type of change

  • [V] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Using my browser spellchecker.

Checklist:

  • [V] Followed the style guidelines of this project

@yehonatanz yehonatanz requested a review from a team January 18, 2023 07:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #3547 (88eb426) into main (5127371) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
- Coverage   93.80%   93.79%   -0.02%     
==========================================
  Files         249      249              
  Lines        7640     7640              
  Branches     1589     1589              
==========================================
- Hits         7167     7166       -1     
- Misses        473      474       +1     
Impacted Files Coverage Δ
packages/opentelemetry-resources/src/Resource.ts 100.00% <ø> (ø)
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@yehonatanz
Copy link
Contributor Author

Looks like merging this will require applying the Skip Changelog label, which I don't seem to have permissions to do.
@legendecas @blumamir @Flarna Would any of you be so kind as to apply it? (Unless of course you think this change warrants a changelog entry)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙂

@pichlermarc pichlermarc merged commit 652d167 into open-telemetry:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants