-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-metrics): use default Resource to comply with semconv #3411
fix(sdk-metrics): use default Resource to comply with semconv #3411
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3411 +/- ##
==========================================
- Coverage 93.26% 93.24% -0.02%
==========================================
Files 247 247
Lines 7347 7348 +1
Branches 1512 1512
==========================================
Hits 6852 6852
- Misses 495 496 +1
|
94a3c3d
to
3f69a72
Compare
@open-telemetry/javascript-maintainers should this be backported? It will result in additional resource attributes usually and users may not expect telemetry to be different in a patch upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits on the changelog entry.
What do you suggest on "backport"? AFAICT, we don't have multiple release lines to be maintained. |
We typically don't backport but i've been trying to think about a release strategy which can put us on a more predictable release cadence without blocking bugs for a long time. We've been releasing basically when we felt like it, which has been a pain point for users waiting on fixes or features. Let's discuss in another issue though. I don't think this bug is a good candidate to test a backport process anyway |
Which problem is this PR solving?
Currently the Metrics SDK does not comply with the resource semantic conventions (see #3410).
This PR changes
MeterProvider
to useResource.default()
(which already contains the required/recommended attributes), which is then merged with the user-provided resource.Fixes #3410
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: