Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(instrumentation-http): move sdk-metrics to dev dependencies #3380

Merged
merged 3 commits into from
Nov 4, 2022
Merged

deps(instrumentation-http): move sdk-metrics to dev dependencies #3380

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a50499
deps(instrumentation-http): move sdk-metrics to dev dependencies.
pichlermarc Nov 3, 2022
db189f6
fix(changelog): add changelog entry
pichlermarc Nov 3, 2022
a93c6f4
Merge branch 'main' into deps/instr-http
pichlermarc Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ All notable changes to experimental packages in this project will be documented

* ci(instrumentation-http): remove got devDependency
[#3347](https://github.com/open-telemetry/opentelemetry-js/issues/3347) @dyladan
* deps(instrumentation-http): move sdk-metrics to dev dependencies [#3380](https://github.com/open-telemetry/opentelemetry-js/issues/3380) @pichlermarc

## 0.33.0

Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-instrumentation-http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"devDependencies": {
"@opentelemetry/api": "^1.0.0",
"@opentelemetry/context-async-hooks": "1.7.0",
"@opentelemetry/sdk-metrics": "0.33.0",
"@opentelemetry/sdk-trace-base": "1.7.0",
"@opentelemetry/sdk-trace-node": "1.7.0",
"@types/mocha": "10.0.0",
Expand Down Expand Up @@ -75,7 +76,6 @@
"@opentelemetry/api-metrics": "0.33.0",
"@opentelemetry/core": "1.7.0",
"@opentelemetry/instrumentation": "0.33.0",
"@opentelemetry/sdk-metrics": "0.33.0",
"@opentelemetry/semantic-conventions": "1.7.0",
"semver": "^7.3.5"
},
Expand Down