Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test API with old node versions #3296

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 5, 2022

Test API with EOL node versions

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #3296 (76edd6c) into main (efb0275) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 76edd6c differs from pull request most recent head 23afb84. Consider uploading reports for the commit 23afb84 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
- Coverage   93.43%   93.42%   -0.02%     
==========================================
  Files         241      241              
  Lines        7253     7253              
  Branches     1507     1507              
==========================================
- Hits         6777     6776       -1     
- Misses        476      477       +1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan dyladan marked this pull request as ready for review October 5, 2022 20:30
@dyladan dyladan requested a review from a team October 5, 2022 20:30
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM. Does the policy that settled in #2721 apply to the API package as well?

@dyladan
Copy link
Member Author

dyladan commented Oct 14, 2022

Code-wise LGTM. Does the policy that settled in #2721 apply to the API package as well?

No. We agreed to keep support in the API as long as we can

@dyladan dyladan merged commit 07a16b7 into open-telemetry:main Oct 14, 2022
@dyladan dyladan deleted the test-old-api branch October 14, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants