-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(exporters): do not append trailing '/' when URL contains path #3274
Merged
dyladan
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/unexpected-root-path-added
Oct 5, 2022
Merged
fix(exporters): do not append trailing '/' when URL contains path #3274
dyladan
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/unexpected-root-path-added
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3274 +/- ##
==========================================
- Coverage 93.44% 93.43% -0.02%
==========================================
Files 241 241
Lines 7249 7253 +4
Branches 1507 1507
==========================================
+ Hits 6774 6777 +3
- Misses 475 476 +1
|
vmarchaud
reviewed
Sep 24, 2022
experimental/packages/exporter-trace-otlp-http/src/platform/browser/OTLPTraceExporter.ts
Show resolved
Hide resolved
Good catch. Thanks for fixing it! 😀 |
svetlanabrennan
approved these changes
Sep 27, 2022
pichlermarc
added
the
priority:p2
Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
label
Sep 30, 2022
vmarchaud
approved these changes
Sep 30, 2022
dyladan
approved these changes
Oct 5, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority:p2
Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When a signal specific environment variable (
OTEL_EXPORTER_OTLP_<signal>_ENDPOINT
) was passed with a url that contains a path not ending inv1/traces
orv1/metrics
, a/
was unexpectedly appended.Fixes #3269
Edit for clarification:
From the spec:
there might be a path part that does not end in
/v1/traces
or/v1/metrics
. With the previous implementation, it would append/
to that path, which can result in404
s, see #3269Short description of the changes
Now parsing the URL on initialization and adding the
/
only when the path is empty.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: