Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove repo specific files from api dir #3260

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Sep 15, 2022

There are various todo tasks that I have added to a file to be done in follow-up PRs. I want to do them separately so it is very clear what each is doing and why.

@dyladan dyladan requested a review from a team September 15, 2022 18:58
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3260 (5708267) into main (d8dabf1) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3260      +/-   ##
==========================================
+ Coverage   93.29%   93.31%   +0.01%     
==========================================
  Files         203      203              
  Lines        6609     6609              
  Branches     1390     1390              
==========================================
+ Hits         6166     6167       +1     
+ Misses        443      442       -1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few open questions 🙂

api/.github/workflows/lint.yaml Show resolved Hide resolved
api/TODO.md Show resolved Hide resolved
api/TODO.md Show resolved Hide resolved
@dyladan dyladan merged commit 6111ae0 into open-telemetry:main Sep 19, 2022
@dyladan dyladan deleted the api-rm-files branch September 19, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants