-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: merge package api docs #3255
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
- Coverage 93.42% 93.03% -0.39%
==========================================
Files 241 226 -15
Lines 7253 6517 -736
Branches 1507 1360 -147
==========================================
- Hits 6776 6063 -713
+ Misses 477 454 -23
|
7105a21
to
a955e63
Compare
These docs are actually on the website I believe already. They shouldn't be maintained in 2 places. Maybe we can replace the website version with a submodule if we want to maintain them here? |
Are there any suggestions on maintaining language-sdk documentation? Should we move all our documents to the website repository? I don't have a strong opinion on this. I agree that we should maintain the documents in one place. |
When you say "language-sdk", who is the intended audience? If it is otel developer docs (e.g., extenders of otel-js) then I think it's fine to keep and maintain here. But if it's end-user docs then it should just live in the website repo. The end-user docs are actively maintained and organized based on working with end users. |
@cartermp the sdk docs he's referring to are the reference docs generated from annotations/comments in the source code. Currently they're published on github.io (https://open-telemetry.github.io/opentelemetry-js/) on each release automatically. The intended audience is typically an SDK end user but they are more of a reference material than how-to docs or anything like that and there is very little editorial work to be done. |
Aha, makes sense! Yeah, those shouldn't be hosted on the website. There may be some interesting future wherein we figure out a good way to represent language API reference docs and explore what website hosting look like, but given that each language has different ways to generate API docs, and developers from those languages will likely expect the format for that generator, and there's 11 languages to worry about ... for the foreseeable future, the website won't do anything other than link to API reference docs. |
+1, yes, for now we have to keep them off the website unfortunately. But we should have a link to them, or even a page that says "API & SDK Docs" or whatever and then point to that external page
I am wondering if we at least could house them within |
I think this makes sense. Linking to it is an easy win though.
Honestly we don't really even need them hosted on github.io. They could easily be hosted on the main website as long as they're in the expected format. |
The browser and webworker test failures seem probably unrelated? |
I created open-telemetry/opentelemetry.io#1808 based on discussion here. No pressing need to engage, but for now we do link to the API reference and will see if there's a way to make it a little more prominent. |
@dyladan no idea why the repo failed to be checkout in web and worker tests. 😕 restarting. |
Thank you all for the clarification. I agree that hosting and maintaining end-user documentation on the website, and SDK documentation in the languages' own repo is a good idea. |
Which problem is this PR solving?
Merge
api/docs
into rootdoc
directory.Type of change
Checklist: