Validate maxExportBatchSize in BatchSpanProcessorBase #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test for this behavior? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3232 +/- ##
==========================================
+ Coverage 93.29% 93.31% +0.01%
==========================================
Files 203 203
Lines 6606 6609 +3
Branches 1389 1390 +1
==========================================
+ Hits 6163 6167 +4
+ Misses 443 442 -1
|
pichlermarc
approved these changes
Sep 12, 2022
|
@dyladan Can you please review the last changes if possible? |
dyladan
reviewed
Sep 14, 2022
packages/opentelemetry-sdk-trace-base/src/export/BatchSpanProcessorBase.ts
Outdated
Show resolved
Hide resolved
pichlermarc
approved these changes
Sep 15, 2022
dyladan
approved these changes
Sep 15, 2022
vmarchaud
approved these changes
Sep 18, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Some exporters' README mention that the maxExportBatchSize parameter in the BatchSpanProcessor must be smaller or equal to maxQueueSize, but no validation is performed in the code.
Fixes #3155
Type of change