feat(node-sdk): added resourceDetectors option to NodeSDK #3210 #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
==========================================
- Coverage 93.22% 93.20% -0.02%
==========================================
Files 196 196
Lines 6491 6492 +1
Branches 1370 1371 +1
==========================================
Hits 6051 6051
- Misses 440 441 +1
|
…com:epsagon/opentelemetry-js into feat/add-sdk-node-resource-detectors-option
|
I guess the change in the protos files is not intended. |
|
@Flarna Fixed, thanks! |
dyladan
reviewed
Aug 31, 2022
Comment on lines
-170
to
+174
| config?: ResourceDetectionConfig | ||
| ): Promise<void> { | ||
| public async detectResources(): Promise<void> { | ||
| const internalConfig: ResourceDetectionConfig = { | ||
| detectors: [envDetector, processDetector], | ||
| ...config, | ||
| detectors: this._resourceDetectors, |
There was a problem hiding this comment.
this is a breaking change please add it to the changelog
Flarna
reviewed
Aug 31, 2022
Co-authored-by: Gerhard Stöbich <[email protected]>
Flarna
approved these changes
Sep 1, 2022
svetlanabrennan
approved these changes
Sep 1, 2022
dyladan
approved these changes
Sep 1, 2022
legendecas
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3210
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: