feat(opentelemetry-api-metrics): Adding generics to create{metricType}

[tomerghelber-tm]

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3151

Short description of the changes

Added generic to create{metricType} methods a the types or the metrics.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• When creating a metric by create{metricType}, it doesn't require labels as a must.
• When creating a metric bycreate{metricType} with labels, the labels are a must.

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tomerghelber-tm / name: Tomer Ghelber (3b1f704)

[legendecas]

Thank you for working on this!

Would you mind adding type conformance tests like https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-sdk-trace-base/test/common/Sampler.test.ts#L39?

[tomerghelber-tm]

Thank you for working on this!

Would you mind adding type conformance tests like https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-sdk-trace-base/test/common/Sampler.test.ts#L39?

Do you mean to check every implementation of every Metric type (Counter, Histogram, etc ...)?

The error should be in "compile time", so I am not sure how to test it.

I understand that the example test checks the values are the expected type, no?

[dyladan]

The error should be in "compile time", so I am not sure how to test it.

You can use the @ts-expect-errror feature of the ts compiler to test this. The compiler will fail if there is not an error if this comment is used.

[codecov]

Codecov Report

Merging #3170 (53743fa) into main (b73c29d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3170   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         203      203           
  Lines        6606     6606           
  Branches     1389     1389           
=======================================
  Hits         6164     6164           
  Misses        442      442           

Impacted Files	Coverage Δ
...ages/opentelemetry-api-metrics/src/types/Metric.ts	100.00% <ø> (ø)

[dyladan]

Any update on @legendecas's comments here?

[tomerghelber-tm]

Removed the NOOP generic and added the tests.

[legendecas]

Overall LGTM. Thank you for working on this. Just a few nits.

[legendecas]

Thank you for working on this!

[legendecas]

Linter is complaining. A format is required.

[dyladan]

Re-ran tests. Flaky test should be fixed by https://github.com/open-telemetry/opentelemetry-js/pull/3242/files