-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(grpc-exporters): remove 'web' as supported from README.md #3070
docs(grpc-exporters): remove 'web' as supported from README.md #3070
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3070 +/- ##
==========================================
- Coverage 93.08% 92.66% -0.42%
==========================================
Files 188 173 -15
Lines 6261 5523 -738
Branches 1323 1175 -148
==========================================
- Hits 5828 5118 -710
+ Misses 433 405 -28
|
@@ -3,7 +3,7 @@ | |||
[![NPM Published Version][npm-img]][npm-url] | |||
[![Apache License][license-image]][license-image] | |||
|
|||
This module provides exporter for web and node to be used with [opentelemetry-collector][opentelemetry-collector-url]. | |||
This module provides exporter for node to be used with [opentelemetry-collector][opentelemetry-collector-url]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this fix, but I think the wording should be "OTLP receiver" instead of "opentelemetry-collector", since the exporter can send to any OTLP compatible receiver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably in other packages as well. Anyway, just sharing a thought. I can open a separate PR after this one is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense. 🙂
Since this PR is already approved I can also do it in a follow-up if you like.
Co-authored-by: Daniel Dyla <[email protected]>
Which problem is this PR solving?
The gRPC exporters for both trace and metrics listed 'web and node' as supported targets, but only 'node' is actually supported.
This PR removes 'web' from the respective
README.md
s.Type of change
Please delete options that are not relevant.
Checklist: