-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export unit block when unit is set in metric descriptor #3041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this! Overall LGTM % a suggestion on tests.
experimental/packages/opentelemetry-exporter-prometheus/test/PrometheusSerializer.test.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-exporter-prometheus/src/PrometheusSerializer.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-exporter-prometheus/test/PrometheusSerializer.test.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-exporter-prometheus/test/PrometheusSerializer.test.ts
Show resolved
Hide resolved
@weyert any update on the comments and conflict? |
Picking this up, been busy switching to latest otel-js at work. Going to have a look at this again. Should have it stashed away somewhere |
Friendly ping :) |
# Conflicts: # experimental/CHANGELOG.md
@open-telemetry/javascript-maintainers I have updated the PR based on the feedback :) |
Which problem is this PR solving?
Updated the
PrometheusSerializer
so that it exports the# UNIT
block of the Prometheus format when theunit
field of a metric descriptor is setFixes #3015 (issue)
Short description of the changes
Added support for exporting the
# UNIT
metadata of a metricType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
# UNIT
-line is exported for a metric that hasunit
setChecklist: