-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grpc-exporter): use non-normalized URL to determine channel security #3019
fix(grpc-exporter): use non-normalized URL to determine channel security #3019
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3019 +/- ##
==========================================
- Coverage 92.78% 91.24% -1.55%
==========================================
Files 185 68 -117
Lines 6142 1850 -4292
Branches 1300 392 -908
==========================================
- Hits 5699 1688 -4011
+ Misses 443 162 -281
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just stumbled upon this
experimental/packages/exporter-trace-otlp-grpc/src/OTLPTraceExporter.ts
Outdated
Show resolved
Hide resolved
@pichlermarc thanks for working on this quickly. When can this be merged and released been waiting on a useable release with an updated proto for a little while now :) |
@mplachter sorry, it did not make it into 0.29.2. I'll sync with the maintainers to see if we can cut another release soon. |
Failing tests are due to unrelated reasons, waiting on #3024 to merge so that the tests go green again. |
Would like to see a review from @svetlanabrennan to ensure we're not missing something since she wrote the original security pr |
Sorry for the delayed review. Looks good to me. |
@dyladan if we could get this merged and released I would really appreciate it. Thank you team for actioning on this :) |
Yay! I did this to workaround the usage of the normalized URL, but it'd be great to eliminate that code. |
Any release plan? |
We'll need to do a feature release. I expect this to come around this week. Sorry for the delay. |
Which problem is this PR solving?
In #2675, @mplachter brought up that the gRPC exporter is currently not working as intended. Investigating this bug revealed that the
collector.url
passed toconfigureSecurity()
was already stripped of its protocol (http://
orhttps://
) which is used to inconfigureSecurity()
to determine the security mode (implemented in #2827).This caused all gRPC exporters configured with URLs containing
http://
to be configured with a secure gRPC channel, and therefore did not work with the (by default insecure) collector gRPC receiver.This PR fixes this issue by passing a URL that still contains the protocol to
configureSecurity()
Type of change
How Has This Been Tested?
otlp-exporter-node
exampleChecklist: