Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency gh-pages to v4 #2985

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 20, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
gh-pages 3.2.3 -> 4.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team May 20, 2022 01:28
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2985 (8fb2935) into main (7b3eab6) will decrease coverage by 2.76%.
The diff coverage is n/a.

❗ Current head 8fb2935 differs from pull request most recent head 80354d6. Consider uploading reports for the commit 80354d6 to get more accurate results

@@            Coverage Diff             @@
##             main    #2985      +/-   ##
==========================================
- Coverage   92.27%   89.51%   -2.77%     
==========================================
  Files         189       76     -113     
  Lines        5941     1983    -3958     
  Branches     1261      449     -812     
==========================================
- Hits         5482     1775    -3707     
+ Misses        459      208     -251     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 79.41% <0.00%> (-17.65%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
...emetry-sdk-metrics-base/src/export/MetricReader.ts
.../exporter-trace-otlp-grpc/src/OTLPTraceExporter.ts
...elemetry-sdk-metrics-base/src/export/MetricData.ts
... and 114 more

@renovate-bot renovate-bot force-pushed the renovate/gh-pages-4.x branch from aa716cd to 6e0e10f Compare May 31, 2022 01:56
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's not breaking then it's probably safe to merge, but I'm curious as to when it is actually being invoked?

As far as I can tell, it is used only in the docs-deploy npm root script:

"docs-deploy": "gh-pages --dotfiles --dist docs",

but when do we run it? Tried to understand it from sources but couldn't follow what the trigger is

@blumamir
Copy link
Member

blumamir commented Jun 9, 2022

As far as I can tell, it is used only in the docs-deploy npm root script:

@dyladan - maybe you know?

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 8, 2022
@renovate-bot renovate-bot force-pushed the renovate/gh-pages-4.x branch from 6e0e10f to 338f7ca Compare August 9, 2022 02:10
@dyladan dyladan merged commit dc2d093 into open-telemetry:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants