Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to reproduce bug with removeListener and once #2970

Conversation

ghisguth
Copy link

@ghisguth ghisguth commented May 13, 2022

This is a reproducer for the bug listed in #2971

@ghisguth ghisguth requested a review from a team May 13, 2022 21:43
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #2970 (dabfd1b) into main (22085fc) will decrease coverage by 2.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2970      +/-   ##
==========================================
- Coverage   92.52%   90.08%   -2.44%     
==========================================
  Files         183       68     -115     
  Lines        5980     1866    -4114     
  Branches     1268      399     -869     
==========================================
- Hits         5533     1681    -3852     
+ Misses        447      185     -262     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...pentelemetry-resources/src/detectors/OSDetector.ts 26.66% <0.00%> (-60.00%) ⬇️
...ntelemetry-resources/src/detectors/HostDetector.ts 23.52% <0.00%> (-52.95%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 68.96% <0.00%> (-20.69%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
... and 115 more

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@pichlermarc
Copy link
Member

Closing this as it has been fixed by #3133. Thank you for providing the reproducer! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants