Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing compiled browser entry points to package #2954

Closed
wants to merge 1 commit into from
Closed

Add missing compiled browser entry points to package #2954

wants to merge 1 commit into from

Conversation

harmony7
Copy link

@harmony7 harmony7 commented May 7, 2022

Which problem is this PR solving?

This PR fixes some missing files entries in package.json files. The missing entries would cause the module and esnext entry points to be excluded from the built NPM packages.

Short description of the changes

Some projects have "module" and "esnext" entries in their package.json, but the referenced files were not being included in their respective package due to them having been left out of the files section.

The issue applies to @opentelemetry/otlp-exporter-base and @opentelemetry/otlp-transformer and was causing problems under Webpack bundling for us.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Building the package locally using the corrected package.json generates a package that includes the missing files.
  • Using this corrected package fixes the Webpack bundling problem I described above.

Checklist:

  • Followed the style guidelines of this project

@harmony7 harmony7 requested a review from a team May 7, 2022 05:19
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 7, 2022

CLA Not Signed

@harmony7
Copy link
Author

harmony7 commented May 7, 2022

Looks like this was fixed, at least for the project that is important for us, by #2952. The other one is probably still a problem, but not blocking for us.

@harmony7 harmony7 closed this May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant