Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds node18 to node_version matrix to enable node18 test #2949

Closed
wants to merge 2 commits into from

Conversation

Keimille
Copy link

@Keimille Keimille commented May 3, 2022

Which problem is this PR solving?
Added node version to matrix in unit-test.yml to extend tests to node 18

Fixes #2935

Short description of the changes
Type of change
Adds node 18 version to unit-test.yml

How Has This Been Tested?
Tested changes in forked repo to ensure desired results in workflow.

@Keimille Keimille requested a review from a team May 3, 2022 12:50
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2949 (4950d63) into main (ddb0775) will not change coverage.
The diff coverage is n/a.

❗ Current head 4950d63 differs from pull request most recent head 341bfd5. Consider uploading reports for the commit 341bfd5 to get more accurate results

@@           Coverage Diff           @@
##             main    #2949   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         185      185           
  Lines        6089     6089           
  Branches     1304     1304           
=======================================
  Hits         5661     5661           
  Misses        428      428           

@Flarna
Copy link
Member

Flarna commented May 3, 2022

Seems tests for node 18 don't run because there are no node.js pre-built binaries for grpc and it doesn't compile.

I think we should skip the effected tests as grpc is deprecated in favor of @grpc/grpc-js and therefore this problem will not go away.

@Keimille
Copy link
Author

Keimille commented May 3, 2022

Seems tests for node 18 don't run because there are no node.js pre-built binaries for grpc and it doesn't compile.

I think we should skip the effected tests as grpc is deprecated in favor of @grpc/grpc-js and therefore this problem will not go away.

Yep, mentioned this in the issue comments, but submitted the PR to raise the issue.

@dyladan
Copy link
Member

dyladan commented May 4, 2022

grpc is only used by the instrumentation-grpc. We should simply skip testing that package on the node 18 tests as grpc package doesn't support node 18 and the instrumentatation-grpc package is only useful if the grpc package is in use.

@Flarna
Copy link
Member

Flarna commented May 4, 2022

instrumentation-grpc takes additionally care of @grpc/grpc-js which is the replacement of grpc and I think we should test it.

@legendecas
Copy link
Member

Thank you for your work on this! However, as #3048 has added the v18.x testing coverage, I'm closing this.

@legendecas legendecas closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend tests to test node 18
4 participants