-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-metrics-base): shutdown and forceflush on MeterProvider #2890
feat(sdk-metrics-base): shutdown and forceflush on MeterProvider #2890
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2890 +/- ##
==========================================
+ Coverage 92.42% 93.64% +1.21%
==========================================
Files 163 165 +2
Lines 5520 5601 +81
Branches 1160 1177 +17
==========================================
+ Hits 5102 5245 +143
+ Misses 418 356 -62
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few non-blocking comments. 🙂
experimental/packages/opentelemetry-sdk-metrics-base/src/MeterProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/test/MeterProvider.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Which problem is this PR solving?
Refs: #2593
Short description of the changes
Promise.all
Type of change
How Has This Been Tested?
Checklist:
Documentation has been updated