-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-metrics-base): coerce histogram boundaries to be implicit Infinity #2859
Merged
legendecas
merged 6 commits into
open-telemetry:main
from
legendecas:metrics-ff/histogram
Mar 31, 2022
Merged
fix(sdk-metrics-base): coerce histogram boundaries to be implicit Infinity #2859
legendecas
merged 6 commits into
open-telemetry:main
from
legendecas:metrics-ff/histogram
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Isn't this the opposite of what @aabmass suggested in his comment. Aaron suggested to always return "OTLP way" which I thought was implicit +Inf. This makes it add +Inf as the last bucket automatically? Unless i've misunderstood the OTLP |
legendecas
changed the title
fix(sdk-metrics-base): coerce histogram boundaries last element to be Infinity
fix(sdk-metrics-base): coerce histogram boundaries to be implicit Infinity
Mar 28, 2022
@dyladan right, I'm having trouble understanding the statements. Updated with implicit lower and upper Infinity bound. |
legendecas
force-pushed
the
metrics-ff/histogram
branch
from
March 28, 2022 02:56
2a82fea
to
ca6c77f
Compare
dyladan
approved these changes
Mar 28, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/view/Aggregation.ts
Outdated
Show resolved
Hide resolved
vmarchaud
approved these changes
Mar 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Refs: #2824 (comment)
Removes leading
-Infinity
lower bound and trailing+Infinity
upper bound forExplicitBucketHistogramAggregation
. Also, move the boundaries sort to Aggregation since a HistogramAggregator could be created with the same boundaries array repetitively.This relax the Exporter implementation requirements -- they don't need to be aware of the original user inputs of missing the last +Inf or not.
Also fixes an unexpected change (#2829) on
HistogramAggregation
that is confused withExplicitBucketsHistogramAggregation
.Type of change
How Has This Been Tested?
Checklist: