Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add parentContext to onStart #2757

Merged
merged 4 commits into from
Feb 6, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 3, 2022

Which problem is this PR solving?

Fixes #2756

Short description of the changes

Add parentContext argument to onStart in SpanProcessors to allow to use it in a subclass without complains by typescript.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

local

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Add parentContext argument to onStart in SpanProcessors to allow to use it in a subclass without
complains by typescript.
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #2757 (0abbfa0) into main (94a0747) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2757   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         159      159           
  Lines        5444     5444           
  Branches     1142     1142           
=======================================
  Hits         5078     5078           
  Misses        366      366           
Impacted Files Coverage Δ
...dk-trace-base/src/export/BatchSpanProcessorBase.ts 94.38% <100.00%> (ø)
...y-sdk-trace-base/src/export/SimpleSpanProcessor.ts 91.30% <100.00%> (ø)

@vmarchaud vmarchaud added the bug Something isn't working label Feb 6, 2022
@vmarchaud vmarchaud merged commit 0dc4c3d into open-telemetry:main Feb 6, 2022
@Flarna Flarna deleted the add-parent-context branch February 6, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does BatchSpanProcessor.onStart() not include the parentContext param?
3 participants