Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-jaeger): add env variable for agent port #2754

Merged
merged 4 commits into from
Feb 8, 2022
Merged

fix(exporter-jaeger): add env variable for agent port #2754

merged 4 commits into from
Feb 8, 2022

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Feb 1, 2022

Which problem is this PR solving?

Exporter Jaeger did not support the OTEL_EXPORTER_JAEGER_AGENT_PORT environment variable from spec.

Short description of the changes

Added this missing environment variable similar to the existing variable OTEL_EXPORTER_JAEGER_AGENT_HOST.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Updated the relevant unit tests with the same pattern as the existing tests for agent host.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated (no need)

@blumamir blumamir requested a review from a team February 1, 2022 16:44
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #2754 (913e111) into main (0dc4c3d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2754   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         159      159           
  Lines        5444     5445    +1     
  Branches     1142     1143    +1     
=======================================
+ Hits         5078     5079    +1     
  Misses        366      366           
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/utils/environment.ts 96.00% <ø> (ø)
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 94.66% <100.00%> (+0.07%) ⬆️

@blumamir
Copy link
Member Author

blumamir commented Feb 1, 2022

node-tests-stable (16) fail but it does not seem to be related to my changes.
tests pass on my local setup with node 16.
is it a known issue?

It was a temporary glitch

@vmarchaud vmarchaud added the enhancement New feature or request label Feb 6, 2022
@vmarchaud vmarchaud requested a review from a team February 6, 2022 10:18
@legendecas legendecas merged commit 31380ac into open-telemetry:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants