Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration-w3c): fix inconsistent api versions loaded #2752

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jan 31, 2022

Which problem is this PR solving?

In the latest changes, one of the package.json is changed and triggered cache invalidations at https://github.com/open-telemetry/opentelemetry-js/blob/main/.github/workflows/w3c-integration-test.yml#L28 and installed @opentelemtry/api with different versions for private package propagation-validation-server (^1.0.3) and lerna package @opentelemtry/sdk-trace-base (~1.0.3 in dev dependencies). Lerna treats this inconsistent semver mark as incompatible semvers and installs different versions for each package.

This leads to the failure of registration of BasicTracerProvider for https://github.com/open-telemetry/opentelemetry-js-api/blob/main/src/internal/global-utils.ts#L53.

Short description of the changes

  • Pin the @opentelemetry/api version in private package propagation-validation-server to ~1.0.3.
  • Hoist all dependencies to align the dependencies versions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2752 (a3762ff) into main (754d96d) will increase coverage by 1.27%.
The diff coverage is n/a.

❗ Current head a3762ff differs from pull request most recent head 712ec2b. Consider uploading reports for the commit 712ec2b to get more accurate results

@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
+ Coverage   92.01%   93.28%   +1.27%     
==========================================
  Files         147      159      +12     
  Lines        4706     5447     +741     
  Branches      990     1142     +152     
==========================================
+ Hits         4330     5081     +751     
+ Misses        376      366      -10     
Impacted Files Coverage Δ
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
packages/exporter-trace-otlp-http/src/types.ts 100.00% <0.00%> (ø)
...exporter-metrics-otlp-http/src/transformMetrics.ts 95.65% <0.00%> (ø)
packages/exporter-trace-otlp-http/src/util.ts 100.00% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 97.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
packages/exporter-trace-otlp-http/src/transform.ts 88.69% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...s/exporter-trace-otlp-http/src/OTLPExporterBase.ts 100.00% <0.00%> (ø)
... and 4 more

@legendecas legendecas marked this pull request as ready for review January 31, 2022 09:10
@legendecas legendecas requested a review from a team January 31, 2022 09:10
@legendecas
Copy link
Member Author

@open-telemetry/javascript-approvers please take a look at this PR as it is blocking for all active PRs.

@vmarchaud vmarchaud merged commit 3231cdc into open-telemetry:main Jan 31, 2022
@legendecas legendecas deleted the fix-w3c branch February 1, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants