Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sdk-metrics-base): test metric instrument interfaces #2743

Merged
merged 7 commits into from
Feb 10, 2022
Merged

test(sdk-metrics-base): test metric instrument interfaces #2743

merged 7 commits into from
Feb 10, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Test coverage on metric instrument interfaces.

Please delete options that are not relevant.

  • test coverage

How Has This Been Tested?

  • Counter
  • UpDownCounter
  • Histogram
  • ObservableCounter
  • ObservableUpDownCounter
  • ObservableGauge

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@legendecas legendecas force-pushed the metrics-ff/instrument branch from fe217b5 to d6cf52e Compare January 27, 2022 09:43
@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #2743 (72d45c5) into main (4fa3270) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2743      +/-   ##
==========================================
+ Coverage   93.28%   93.42%   +0.14%     
==========================================
  Files         159      159              
  Lines        5448     5448              
  Branches     1144     1144              
==========================================
+ Hits         5082     5090       +8     
+ Misses        366      358       -8
Impacted Files Coverage Δ
.../opentelemetry-sdk-metrics-base/src/Instruments.ts 100.00% <0.00%> (+42.10%) ⬆️

@legendecas legendecas marked this pull request as ready for review January 27, 2022 09:57
@legendecas legendecas requested a review from a team January 27, 2022 09:57
pichlermarc
pichlermarc approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@vmarchaud vmarchaud requested a review from dyladan February 6, 2022 10:41
@legendecas
Copy link
Member Author

@dyladan friendly ping :)

@legendecas legendecas merged commit ba177fa into open-telemetry:main Feb 10, 2022
@legendecas legendecas deleted the metrics-ff/instrument branch February 10, 2022 02:14
@dyladan dyladan mentioned this pull request Mar 16, 2022
Merged
@pichlermarc pichlermarc mentioned this pull request Apr 22, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legendecas @dyladan @vmarchaud @pichlermarc @srikanthccv