docs: specify minimun version of npm to run command in subproject #2728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cuichen Li [email protected]
Which problem is this PR solving?
The
CONTRIBUTING
document did not specify clearly the minimum version ofnpm
and I am getting errors when trying to runlint
in subprojects sayscan not find eslint
. Turns out I was using[email protected]
, which does not have the algorithm to find binary in parentnode_modules
. By upgrading it to at least7.x
can fix the issue.This may be one edge case (I do not know how many people are still using this version nowadays). But by using
nvm
to installnode14
we would get[email protected]
.