fix: span events count limit when set to 0 #2679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
If span events count limit (OTEL_SPAN_EVENT_COUNT_LIMIT) is set to 0 there should be no events in the span. Current implementation allows adding 1 event when the limit is set to 0.
Fixes #2670
Short description of the changes
Span's
addEvent
function updated. If the limit is set to 0, it adds log that no event are allowed and returns.Type of change
How Has This Been Tested?