-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update wip metrics references #2638
Conversation
The branch history seems not clean and contains unrelated changes? |
I think thats because he pushed into |
@legendecas fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the main branch there should be 9 references on @opentelemetry/api-metrics and they should all be updated with wip I think?
@legendecas thanks not sure how I missed those |
I think i missed them because of the history mixup |
Codecov Report
@@ Coverage Diff @@
## main #2638 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 123 123
Lines 4758 4759 +1
Branches 1061 1061
=======================================
+ Hits 4430 4431 +1
Misses 328 328
|
In #2629 the metrics API and SDK packages were renamed and made private to prevent them from being linked with other packages by lerna. This PR cleans up some references that were missed and still point to the released API.