Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update wip metrics references #2638

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 22, 2021

In #2629 the metrics API and SDK packages were renamed and made private to prevent them from being linked with other packages by lerna. This PR cleans up some references that were missed and still point to the released API.

@dyladan dyladan requested a review from a team November 22, 2021 16:11
@legendecas
Copy link
Member

The branch history seems not clean and contains unrelated changes?

@vmarchaud
Copy link
Member

The branch history seems not clean and contains unrelated changes?

I think thats because he pushed into wip-metrics-cleanup instead of main

@dyladan
Copy link
Member Author

dyladan commented Nov 22, 2021

@legendecas fixed

@dyladan dyladan changed the base branch from wip-metrics-cleanup to main November 22, 2021 20:59
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the main branch there should be 9 references on @opentelemetry/api-metrics and they should all be updated with wip I think?

@dyladan
Copy link
Member Author

dyladan commented Nov 24, 2021

@legendecas thanks not sure how I missed those

@dyladan
Copy link
Member Author

dyladan commented Nov 24, 2021

I think i missed them because of the history mixup

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #2638 (154261e) into main (5e9c7e1) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 154261e differs from pull request most recent head 90ba0ae. Consider uploading reports for the commit 90ba0ae to get more accurate results

@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files         123      123           
  Lines        4758     4759    +1     
  Branches     1061     1061           
=======================================
+ Hits         4430     4431    +1     
  Misses        328      328           
Impacted Files Coverage Δ
...entelemetry-sdk-metrics-base/src/view/Predicate.ts 100.00% <0.00%> (ø)

@vmarchaud vmarchaud merged commit 14afcc1 into open-telemetry:main Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants