Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the compilation for typescript 4.4 #2623

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 15, 2021

Looks like updating to typescript 4.4 caused the compilation to break due to errors being recognized as unknown types. This disables that option temporarily and in a follow-up PR I will update the repo to take advantage of the new default behavior.

@dyladan dyladan requested a review from a team November 15, 2021 19:42
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #2623 (bfd6665) into main (6b77b67) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   92.88%   93.26%   +0.37%     
==========================================
  Files         105      115      +10     
  Lines        3978     4645     +667     
  Branches      901     1036     +135     
==========================================
+ Hits         3695     4332     +637     
- Misses        283      313      +30     
Impacted Files Coverage Δ
...exporter-metrics-otlp-http/src/transformMetrics.ts 95.65% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.98% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...elemetry-exporter-trace-otlp-http/src/transform.ts 88.69% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...pentelemetry-exporter-trace-otlp-http/src/types.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...opentelemetry-exporter-trace-otlp-http/src/util.ts 100.00% <0.00%> (ø)
...y-exporter-trace-otlp-http/src/OTLPExporterBase.ts 92.15% <0.00%> (ø)

@vmarchaud vmarchaud merged commit d128f0f into open-telemetry:main Nov 15, 2021
@dyladan dyladan deleted the fix-compilation branch November 15, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants