fix: fixing compatibility versions for detectors #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
reviewed
Nov 2, 2021
Codecov Report
@@ Coverage Diff @@
## main #2584 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 138 138
Lines 5092 5092
Branches 1095 1095
=======================================
Hits 4736 4736
Misses 356 356 |
dyladan
approved these changes
Nov 4, 2021
legendecas
approved these changes
Nov 5, 2021
vmarchaud
approved these changes
Nov 5, 2021
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
detectors from SDK package hasn't been updated and latest package contains incompatible detectors versions. Once this is merged we should release this package
We should still do something about it for longer term -> #2583