Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: code cleanup #256

Merged
merged 2 commits into from
Sep 15, 2019
Merged

chore: code cleanup #256

merged 2 commits into from
Sep 15, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

@codecov-io
Copy link

Codecov Report

Merging #256 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   98.93%   98.88%   -0.05%     
==========================================
  Files          67       65       -2     
  Lines        2626     2521     -105     
  Branches      169      168       -1     
==========================================
- Hits         2598     2493     -105     
  Misses         28       28
Impacted Files Coverage Δ
...telemetry-node-tracer/src/instrumentation/utils.ts 100% <ø> (+3.44%) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <ø> (ø) ⬆️
...pentelemetry-basic-tracer/src/NoopSpanProcessor.ts 75% <0%> (-25%) ⬇️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-basic-tracer/src/config.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...sic-tracer/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...metry-basic-tracer/test/MultiSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...ic-tracer/test/export/InMemorySpanExporter.test.ts 100% <0%> (ø) ⬆️
... and 3 more

4 similar comments
@codecov-io
Copy link

Codecov Report

Merging #256 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   98.93%   98.88%   -0.05%     
==========================================
  Files          67       65       -2     
  Lines        2626     2521     -105     
  Branches      169      168       -1     
==========================================
- Hits         2598     2493     -105     
  Misses         28       28
Impacted Files Coverage Δ
...telemetry-node-tracer/src/instrumentation/utils.ts 100% <ø> (+3.44%) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <ø> (ø) ⬆️
...pentelemetry-basic-tracer/src/NoopSpanProcessor.ts 75% <0%> (-25%) ⬇️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-basic-tracer/src/config.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...sic-tracer/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...metry-basic-tracer/test/MultiSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...ic-tracer/test/export/InMemorySpanExporter.test.ts 100% <0%> (ø) ⬆️
... and 3 more

@codecov-io
Copy link

Codecov Report

Merging #256 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   98.93%   98.88%   -0.05%     
==========================================
  Files          67       65       -2     
  Lines        2626     2521     -105     
  Branches      169      168       -1     
==========================================
- Hits         2598     2493     -105     
  Misses         28       28
Impacted Files Coverage Δ
...telemetry-node-tracer/src/instrumentation/utils.ts 100% <ø> (+3.44%) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <ø> (ø) ⬆️
...pentelemetry-basic-tracer/src/NoopSpanProcessor.ts 75% <0%> (-25%) ⬇️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-basic-tracer/src/config.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...sic-tracer/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...metry-basic-tracer/test/MultiSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...ic-tracer/test/export/InMemorySpanExporter.test.ts 100% <0%> (ø) ⬆️
... and 3 more

@codecov-io
Copy link

Codecov Report

Merging #256 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   98.93%   98.88%   -0.05%     
==========================================
  Files          67       65       -2     
  Lines        2626     2521     -105     
  Branches      169      168       -1     
==========================================
- Hits         2598     2493     -105     
  Misses         28       28
Impacted Files Coverage Δ
...telemetry-node-tracer/src/instrumentation/utils.ts 100% <ø> (+3.44%) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <ø> (ø) ⬆️
...pentelemetry-basic-tracer/src/NoopSpanProcessor.ts 75% <0%> (-25%) ⬇️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-basic-tracer/src/config.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...sic-tracer/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...metry-basic-tracer/test/MultiSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...ic-tracer/test/export/InMemorySpanExporter.test.ts 100% <0%> (ø) ⬆️
... and 3 more

@codecov-io
Copy link

Codecov Report

Merging #256 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   98.93%   98.88%   -0.05%     
==========================================
  Files          67       65       -2     
  Lines        2626     2521     -105     
  Branches      169      168       -1     
==========================================
- Hits         2598     2493     -105     
  Misses         28       28
Impacted Files Coverage Δ
...telemetry-node-tracer/src/instrumentation/utils.ts 100% <ø> (+3.44%) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <ø> (ø) ⬆️
...pentelemetry-basic-tracer/src/NoopSpanProcessor.ts 75% <0%> (-25%) ⬇️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-basic-tracer/src/config.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...sic-tracer/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...metry-basic-tracer/test/MultiSpanProcessor.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...ic-tracer/test/export/InMemorySpanExporter.test.ts 100% <0%> (ø) ⬆️
... and 3 more

@codecov-io
Copy link

codecov-io commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #256 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   98.87%   98.94%   +0.07%     
==========================================
  Files          67       66       -1     
  Lines        2569     2652      +83     
  Branches      172      174       +2     
==========================================
+ Hits         2540     2624      +84     
+ Misses         29       28       -1
Impacted Files Coverage Δ
...telemetry-node-tracer/src/instrumentation/utils.ts 96% <ø> (+4%) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <ø> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️

@mayurkale22 mayurkale22 merged commit 84567f5 into open-telemetry:master Sep 15, 2019
@mayurkale22 mayurkale22 deleted the cleanup branch September 15, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@draffensperger draffensperger draffensperger approved these changes

@bg451 bg451 Awaiting requested review from bg451

@danielkhan danielkhan Awaiting requested review from danielkhan

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayurkale22 @codecov-io @draffensperger @OlivierAlbertini