-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split stable and experimental packages into groups using directories #2462
Conversation
b5e8c31
to
2f53dfe
Compare
Codecov Report
@@ Coverage Diff @@
## main #2462 +/- ##
==========================================
- Coverage 93.32% 92.60% -0.73%
==========================================
Files 135 137 +2
Lines 4932 5017 +85
Branches 1042 1060 +18
==========================================
+ Hits 4603 4646 +43
- Misses 329 371 +42
|
0ef4843
to
15e6ccb
Compare
In general changes are fine, but I wish to understand how will this be different (or not at all) from what we have now
thx |
No difference except when working on experimental packages you will have to cd into the experimental directory before running commands.
No change except when working on experimental you will need to cd into the experimental directory to run commands. PRs that touch both experimental and stable will not work if the experimental changes depend on unreleased stable functionality. You will have to merge stable, wait for release, then work on experimental. If you want to locally make sure your stable changes work the way you expect with experimental changes before they are released, you can add
Commands are the same but they have to be run once for each package group. I will port the existing automation from contrib, one for each package group. Will update the releasing md to make this clear. Order does not matter because any PR in experimental which depended on a stable change would not even be able to merge until after the stable is released so it can never be in a broken state. Stable will never depend on experimental.
Works the exact same way as it does now. Examples which show off experimental features should be moved to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
056242e
to
bcfb4c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
No description provided.