Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced word plugin with instrumentation #2352

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

niko-achilles
Copy link
Contributor

Which problem is this PR solving?

  • website_docs , consistency in using words plugin versus instrumentation. Replaced the word plugin with instrumentation

Short description of the changes

  • The package for instrumentation of document load is named @opentelemetry/instrumentation-document-load . But the website_docs use often the word plugin in order to reference this instrumentation, e.g by informing the user to install the @opentelemetry/plugin-document-load . It should actually be: @opentelemetry/instrumentation-document-load

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 15, 2021

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Niko Achilles Kokkinos (2f98ed7)

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2352 (6d6ffa0) into main (68454a4) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 6d6ffa0 differs from pull request most recent head 2f98ed7. Consider uploading reports for the commit 2f98ed7 to get more accurate results

@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
- Coverage   92.77%   92.63%   -0.14%     
==========================================
  Files         145      142       -3     
  Lines        5216     5091     -125     
  Branches     1068     1047      -21     
==========================================
- Hits         4839     4716     -123     
+ Misses        377      375       -2     
Impacted Files Coverage Δ
...async-hooks/src/AsyncLocalStorageContextManager.ts
...ontext-async-hooks/src/AsyncHooksContextManager.ts
...sync-hooks/src/AbstractAsyncHooksContextManager.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants