Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use single quotes everywhere and add a rule to eslint #2351

Merged
merged 3 commits into from
Jul 21, 2021
Merged

style: use single quotes everywhere and add a rule to eslint #2351

merged 3 commits into from
Jul 21, 2021

Conversation

blumamir
Copy link
Member

Which problem is this PR solving?

The codebase is using a single quote for strings almost everywhere, but there is no such rule in eslint, and some files are written with double quotes and are not fixed automatically by the linter.

Short description of the changes

Add a rule for eslint: "quotes": [2, "single", { "avoidEscape": true }] and run lint:fix to replace double quotes with single quotes where it's not consistent.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #2351 (146433f) into main (56de304) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2351   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         143      143           
  Lines        5136     5136           
  Branches     1052     1052           
=======================================
  Hits         4771     4771           
  Misses        365      365           
Impacted Files Coverage Δ
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 90.90% <100.00%> (ø)
...ackages/opentelemetry-shim-opentracing/src/shim.ts 94.25% <100.00%> (ø)

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems quite some formatting rules got lost during removing gts/prettier.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants