-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated spec to v1.5.0 and renamed resource class #2345
feat: updated spec to v1.5.0 and renamed resource class #2345
Conversation
Updated the specification to the latest version 1.5.0 Renamed the `ResourceAttributes` to `SemanticResourceAttributes` fixes open-telemetry#2299
19 seconds old PR already has conflicts 😆 |
Hmm, I don't understand why it can not find |
Codecov Report
@@ Coverage Diff @@
## main #2345 +/- ##
==========================================
- Coverage 92.77% 92.76% -0.02%
==========================================
Files 145 145
Lines 5221 5221
Branches 1070 1070
==========================================
- Hits 4844 4843 -1
- Misses 377 378 +1
|
I am not sure why the browser test is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just missing one thing to update main readme.md with information about breaking changes
creating a corresponding issue in contrib repo open-telemetry/opentelemetry-js-contrib#574 |
Good point, I will update it first thing tomorrow :) |
Added the READMe.md change @obecny |
can you revert the formatting it had ? |
Wouldn't making the changes in the examples break all of them until the release of the semantic conventions package with the changes? |
Updated :) Think I finally managed to disable Prettier for this project in Visual Studio Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for updating the README header as well
One more approval and please fix the conflict and this will be good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@weyert i merged main into the PR but didn't change a quote sorry, could you fix this ? |
Which problem is this PR solving?
Resolves ticket #2299
Short description of the changes
Updated the specification to the latest version 1.5.0 so the latest semantic convention attributes will be available (e.g. mobile ones)
Renamed the
ResourceAttributes
toSemanticResourceAttributes