-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ComponentLogger into instrumentations #2261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
June 7, 2021 21:21
Codecov Report
@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
- Coverage 92.79% 92.72% -0.08%
==========================================
Files 144 144
Lines 5178 5179 +1
Branches 1060 1060
==========================================
- Hits 4805 4802 -3
- Misses 373 377 +4
|
MSNev
approved these changes
Jun 7, 2021
Is this change related to the log spec? |
vmarchaud
approved these changes
Jun 9, 2021
nope, just to be able to debug which component is emitting logs |
dyladan
approved these changes
Jun 9, 2021
Merged
This was referenced Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.