-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update typescript to 4.3 and enable noImplicitOverride #2241
Conversation
Enable typescript 4.3 feature noImplicitOverride to improve code quality and adapt code as needed. Besides that I updated eslint.
Codecov Report
@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 92.31% 92.29% -0.02%
==========================================
Files 144 144
Lines 5168 5168
Branches 1064 1064
==========================================
- Hits 4771 4770 -1
- Misses 397 398 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Flarna are you planning to do the same on api and contrib ? |
I have already a branch with the changes for API but current version of prettier (used via gts) is not yet ready for |
I will remove gts/prettier from API and contrib like I did for this repo. |
Sounds good. But it seems quite some formatting rules got lost in this repo. Not sure if this should be handled first. |
Enable typescript 4.3 feature noImplicitOverride to improve code quality and adapt code as needed.
Besides that I updated eslint.