Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency require-in-the-middle to v5 #223

Merged

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Update out-of-date dependency: require-in-the-middle

Short description of the changes

  • In the future, we have planned to enable renovate on this repo to manage automated dependency updates.

@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #223 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   94.59%   94.57%   -0.03%     
==========================================
  Files          51       51              
  Lines        1906     1898       -8     
  Branches      128      128              
==========================================
- Hits         1803     1795       -8     
  Misses        103      103
Impacted Files Coverage Δ
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <0%> (ø) ⬆️

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22 mayurkale22 merged commit 9785974 into open-telemetry:master Aug 27, 2019
@mayurkale22 mayurkale22 deleted the require-in-the-middle-5.x branch August 27, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants