feat(shim-opentracing): update setTag based on new spec

[vreynolds]

Which problem is this PR solving?

• Per updated spec, setTag must map error tag to status code (true --> Error, false --> Ok)
  • https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opentracing.md#set-tag
• This changes existing shim behavior when setting tags (previously only error: true mapped to status code)
• Updates Update the OT Shim layer #2030

Short description of the changes

• Update setTag to match spec
  • Note: any error tag that's not true/false will default to Unset status code
• Update addTags to match setTag spec

Questions

• Should addTags map error tags to status code as well? (Not defined in the OTEL spec, since it's not in the OpenTracing spec) I updated addTags as well, since that seems like the spirit of the spec.

[codecov]

Codecov Report

Merging #2194 (3c0ff22) into main (8bb9752) will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2194      +/-   ##
==========================================
+ Coverage   92.28%   92.79%   +0.51%     
==========================================
  Files         127      144      +17     
  Lines        4186     5178     +992     
  Branches      852     1062     +210     
==========================================
+ Hits         3863     4805     +942     
- Misses        323      373      +50     

Impacted Files	Coverage Δ
...ackages/opentelemetry-shim-opentracing/src/shim.ts	93.00% <100.00%> (+3.40%)	⬆️
...-instrumentation-fetch/src/enums/AttributeNames.ts	100.00% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts	100.00% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts	100.00% <0.00%> (ø)
.../opentelemetry-exporter-collector/src/transform.ts	88.69% <0.00%> (ø)
...kages/opentelemetry-exporter-collector/src/util.ts	100.00% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts	96.98% <0.00%> (ø)
...ry-exporter-collector/src/CollectorExporterBase.ts	92.15% <0.00%> (ø)
packages/opentelemetry-web/src/utils.ts	94.80% <0.00%> (ø)
...lemetry-exporter-collector/src/transformMetrics.ts	95.71% <0.00%> (ø)
... and 8 more

[vmarchaud]

Should addTags map error tags to status code as well? (Not defined in the OTEL spec, since it's not in the OpenTracing spec)

Not sure what you meant here ?

[vreynolds]

Should addTags map error tags to status code as well? (Not defined in the OTEL spec, since it's not in the OpenTracing spec)

Not sure what you meant here ?

There is an addTags method in the opentracing-js API, which sets multiple tags at once. I was unsure if the shim should look at each tag in the args, and map any error tags to status, like setTag does. It's not explicitly in the spec, because I think it might be an opentracing-js thing.

[vmarchaud]

There is an addTags method in the opentracing-js API, which sets multiple tags at once. I was unsure if the shim should look at each tag in the args, and map any error tags to status, like setTag does. It's not explicitly in the spec, because I think it might be an opentracing-js thing.

As my other comment, i would suggest to do what you think is best given the time you have !

[vmarchaud]

lgtm, thanks for taking the time to fix this !

[obecny]

lgtm

[vmarchaud]

@vreynolds Could you rebase the PR ? There is one conflict :/

[vmarchaud]

@vreynolds Sorry but it seems there is still conflict

[dyladan]

Looks great to me but there is still a conflict

[vreynolds]

Thanks for merging upstream @dyladan ! Looks like conflicts have been resolved, but LMK if there's anything more I can do.