Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): add grpc plugin #215

Merged
merged 19 commits into from
Sep 11, 2019
Merged

feat(plugin): add grpc plugin #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0db3a5b
feat: add grpc plugin
markwolff Aug 22, 2019
52d5024
fix: remove test typo
markwolff Aug 22, 2019
92ef3c5
fix: nyc missing from test
markwolff Aug 22, 2019
5382516
fix: linting and NodeTracer export
markwolff Aug 22, 2019
dfb24f0
chore: rename grpc test file
markwolff Aug 29, 2019
08e0fba
test: add error code tests
markwolff Aug 30, 2019
052dc53
Merge branch 'master' into add-grpc-plugin
markwolff Aug 30, 2019
02c1d4c
refactor: logger is given to plugin
markwolff Aug 30, 2019
91d8a25
Merge branch 'master' into add-grpc-plugin
markwolff Aug 30, 2019
64a805d
fix(grpc): using logger before defined
markwolff Aug 30, 2019
aefc3e4
refactor: move private statics to internal file
markwolff Sep 4, 2019
f0bac7b
test: add withSpan OK test
markwolff Sep 4, 2019
2d01b61
refactor: follow plugin naming pattern
markwolff Sep 4, 2019
e9793a4
Merge branch 'master' into add-grpc-plugin
markwolff Sep 5, 2019
8633a7f
refactor(tests): replace ProxyTracer
markwolff Sep 5, 2019
798bc4b
refactor(grpc): move helper funcs to utils
markwolff Sep 9, 2019
51bb59c
Merge branch 'master' into add-grpc-plugin
markwolff Sep 9, 2019
df5aed8
refactor(tests): use new memory exporter helper
markwolff Sep 9, 2019
4eed3e8
Merge branch 'master' into add-grpc-plugin
mayurkale22 Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/opentelemetry-plugin-grpc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"types": "build/src/index.d.ts",
"repository": "open-telemetry/opentelemetry-js",
"scripts": {
"test": "nyc ts-mocha -p tsconfig.json 'test/**/*.ts'",
"test": "nyc ts-mocha -p tsconfig.json test/**/*.test.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to keep it standardized everywhere, either change all packages script to test/**/*.test.ts or keep it test/**/*.ts. WDYT?

"tdd": "yarn test -- --watch-extensions ts --watch",
"clean": "rimraf build/*",
"check": "gts check",
Expand Down Expand Up @@ -39,7 +39,10 @@
"devDependencies": {
"@types/mocha": "^5.2.7",
"@types/node": "^12.6.9",
"@types/protobufjs": "^6.0.0",
"@types/shimmer": "^1.0.1",
"codecov": "^3.5.0",
"grpc": "^1.23.3",
"gts": "^1.1.0",
"mocha": "^6.2.0",
"nyc": "^14.1.1",
Expand All @@ -48,8 +51,12 @@
"typescript": "^3.5.3"
},
"dependencies": {
"@opentelemetry/basic-tracer": "^0.0.1",
"@opentelemetry/core": "^0.0.1",
"@opentelemetry/node-tracer": "^0.0.1",
"@opentelemetry/types": "^0.0.1"
"@opentelemetry/scope-async-hooks": "^0.0.1",
"@opentelemetry/types": "^0.0.1",
"shimmer": "^1.2.1",
"semver": "^6.3.0"
}
}
24 changes: 24 additions & 0 deletions packages/opentelemetry-plugin-grpc/src/enums/AttributeNames.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/**
* Copyright 2019, OpenTelemetry Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

export enum AttributeNames {
COMPONENT = 'component',
GRPC_KIND = 'grpc.kind', // SERVER or CLIENT
GRPC_METHOD = 'grpc.method',
GRPC_STATUS_CODE = 'grpc.status_code',
GRPC_ERROR_NAME = 'grpc.error_name',
GRPC_ERROR_MESSAGE = 'grpc.error_message',
}
Loading