-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: link net
and http
instrumentations correctly
#2046
fix: link net
and http
instrumentations correctly
#2046
Conversation
outgoing context is still activated to enable connect instrumentation
…try-js into fix-http-insrumentation
Codecov Report
@@ Coverage Diff @@
## main #2046 +/- ##
==========================================
+ Coverage 92.99% 93.01% +0.02%
==========================================
Files 152 152
Lines 5938 5944 +6
Branches 1236 1237 +1
==========================================
+ Hits 5522 5529 +7
+ Misses 416 415 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this; looks like a clean fix to the issue.
Which problem is this PR solving?
http
instrumentation did not activate the context of the outgoing request span before doing the request, thusnet
instrumentation received the wrong active context.Context in the callbacks / event emitters is unchanged, i.e. it is the parent context.
Short description of the changes
Examples show an express app receiving an http request which invokes an outbound http request.
Before
After