-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint on shadowing in non-test sources, fix a few of them #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbley
requested review from
dyladan,
Flarna,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
February 10, 2021 15:57
Codecov Report
@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
+ Coverage 92.74% 92.75% +0.01%
==========================================
Files 174 177 +3
Lines 6108 6200 +92
Branches 1265 1291 +26
==========================================
+ Hits 5665 5751 +86
- Misses 443 449 +6
|
obecny
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one suggestion hope you can address it before merging
MSNev
approved these changes
Feb 12, 2021
Flarna
approved these changes
Feb 15, 2021
dyladan
approved these changes
Feb 16, 2021
vmarchaud
approved these changes
Feb 17, 2021
@johnbley can you please resolve conflicts ? |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1882. As suggested, this is only a lint warning, not an error, due to some false positives. Additionally, since so
many spurious warnings were given for
it
blocks in tests, disable the rule for test sources.