Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove NoRecordingSpan #1900

Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 4, 2021

NoRecordingSpan doesn't add anything on top of NoopSpan and it's only used at one few places.

Remove it in favor of NoopSpan.

Nice side effect is that instrumentation http is no longer depending on core.

NoRecordingSpan doesn't add anything on top of NoopSpan and it's only used at one place.

Remove it in favor of NoopSpan.
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1900 (fda147f) into main (2f0d612) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   92.75%   92.68%   -0.07%     
==========================================
  Files         173      172       -1     
  Lines        5973     5963      -10     
  Branches     1269     1268       -1     
==========================================
- Hits         5540     5527      -13     
- Misses        433      436       +3     
Impacted Files Coverage Δ
...ges/opentelemetry-instrumentation-http/src/http.ts 94.69% <100.00%> (-0.86%) ⬇️
packages/opentelemetry-plugin-http/src/http.ts 97.31% <100.00%> (-0.02%) ⬇️
packages/opentelemetry-tracing/src/Tracer.ts 100.00% <100.00%> (ø)
...etry-exporter-prometheus/src/PrometheusExporter.ts 91.04% <0.00%> (-1.50%) ⬇️

@Flarna Flarna added the breaking label Feb 4, 2021
@dyladan dyladan merged commit cacbbdc into open-telemetry:main Feb 8, 2021
@dyladan dyladan deleted the rm-norecordingspan branch February 8, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants