Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exporter): replace Span with ReadableSpan #189

Merged
merged 1 commit into from
Aug 13, 2019
Merged

fix(exporter): replace Span with ReadableSpan #189

merged 1 commit into from
Aug 13, 2019

Conversation

mayurkale22
Copy link
Member

No description provided.

@mayurkale22 mayurkale22 requested a review from bg451 August 9, 2019 22:52
OlivierAlbertini
OlivierAlbertini approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22 mayurkale22 merged commit 4bf949d into open-telemetry:master Aug 13, 2019
@mayurkale22 mayurkale22 deleted the use_readablespan branch August 13, 2019 15:05
@mayurkale22 mayurkale22 mentioned this pull request Aug 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@rochdev rochdev rochdev approved these changes

@bg451 bg451 bg451 approved these changes

@danielkhan danielkhan Awaiting requested review from danielkhan

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayurkale22 @bg451 @rochdev @OlivierAlbertini