Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add public 'fields' function to api.propagator #1813

Merged
merged 5 commits into from
Jan 13, 2021
Merged

fix(api): add public 'fields' function to api.propagator #1813

merged 5 commits into from
Jan 13, 2021

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Jan 13, 2021

Which problem is this PR solving?

Short description of the changes

  • add fields function to api.propagator, which calls fields function on the global propagator and return the result

@dyladan dyladan added the API label Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1813 (c89ce15) into master (139d9db) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   92.44%   92.51%   +0.07%     
==========================================
  Files         171      173       +2     
  Lines        5913     6038     +125     
  Branches     1264     1284      +20     
==========================================
+ Hits         5466     5586     +120     
- Misses        447      452       +5     
Impacted Files Coverage Δ
...y-api/src/context/propagation/TextMapPropagator.ts 14.28% <ø> (ø)
packages/opentelemetry-api/src/api/propagation.ts 93.33% <100.00%> (+0.47%) ⬆️
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 95.86% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)

@dyladan dyladan merged commit fadebf3 into open-telemetry:master Jan 13, 2021
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
…try#1813)

* fix(api): add public 'fields' function to api.propagator

* chore: remove redundant comment

Co-authored-by: Daniel Dyla <[email protected]>
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
…try#1813)

* fix(api): add public 'fields' function to api.propagator

* chore: remove redundant comment

Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api.propagation.fields should be public
5 participants